Tidy schedule, enum, and integration cleanups - #413
Merged
Conversation
Resolves a batch of small code-quality issues: - ScheduleStatusEnum::upcoming() returned the same set as incomplete() ([upcoming, in_progress]); it now returns only [upcoming]. (#340) - Removed the never-persisted $status property from Create/Update ScheduleRequestData — the schedules.status column was dropped and the value was silently ignored. (#337) - Added ExternalProviderEnum::componentStatus() to centralise the OhDear 'up'/'down' to ComponentStatusEnum mapping, replacing the raw magic string in ImportOhDearFeed. (#339) - Deleted the dead UserLevelEnum (the User model uses the is_admin boolean) and its now-orphaned user.level translations. (#338) - Documented that components in a performance_issues state intentionally roll up to SystemStatusEnum::partial_outage. (#342) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PjCvFouVaM9DEmL7kHZj8M
jbrooksuk
force-pushed
the
claude/cachethq-core-issues-review-iga64v
branch
from
August 5, 2026 08:20
1680041 to
f20ad81
Compare
jbrooksuk
marked this pull request as ready for review
August 5, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This batch resolves small code-quality issues across schedules, enums, and the Oh Dear integration.
Validation